Fix loading datasets traffic_2008_10T and traffic_2008_hourly
#462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-462--etna-docs.netlify.app |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #462 +/- ##
==========================================
- Coverage 90.41% 90.41% -0.01%
==========================================
Files 229 229
Lines 15940 15939 -1
==========================================
- Hits 14412 14411 -1
Misses 1528 1528 ☔ View full report in Codecov by Sentry. |
brsnw250
requested changes
Aug 29, 2024
| date(2009, 1, 1), | ||
| date(2009, 1, 19), | ||
| date(2009, 2, 16), | ||
| ] + [date(2008, 3, 8), date(2009, 3, 9)] |
There was a problem hiding this comment.
We can include this dates in the list above, maybe add a comment if needed
brsnw250
approved these changes
Aug 29, 2024
|
May be we can write issue to |
|
Created a bug: vacanza/python-holidays#1963 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
Fix holidays dates. It seems like on new version of
holidaysthe holidays aren't correct. There were also incorrect holidays with missing values. The new values are taken from the sourceClosing issues
Closes #455.